refactor: avoid deprecated code #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Haroenv
commented
Jul 27, 2022
- eslint warning (not error as that would be ignored) for deprecated code usage
- removal of a lot of the deprecated code
This is not an error, as otherwise we'd be inclined to ignore the error, whic isn't the point here.
Hits is deprecated, as the usage was inconsistent, and it's easier to enforce usage of the array form than the plural form
…nent They are already aliased to eachother, but the deprecated form was used in the component
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d9837a5:
|
Haroenv
requested review from
a team,
dhayab (assigned from algolia/frontend-experiences-web) and
sarahdayan (assigned from algolia/frontend-experiences-web)
and removed request for
a team
dhayab
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.