Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid deprecated code #5082

merged 8 commits into from Sep 5, 2022

refactor: avoid deprecated code #5082

merged 8 commits into from Sep 5, 2022


Copy link

@Haroenv Haroenv commented Jul 27, 2022

  • eslint warning (not error as that would be ignored) for deprecated code usage
  • removal of a lot of the deprecated code

Haroenv added 5 commits Jul 27, 2022
This is not an error, as otherwise we'd be inclined to ignore the error, whic isn't the point here.
Hits is deprecated, as the usage was inconsistent, and it's easier to enforce usage of the array form than the plural form

They are already aliased to eachother, but the deprecated form was used in the component
Copy link

codesandbox-ci bot commented Jul 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9837a5:

Sandbox Source
InstantSearch.js Configuration

@Haroenv Haroenv requested review from a team, dhayab (assigned from algolia/frontend-experiences-web) and sarahdayan (assigned from algolia/frontend-experiences-web) and removed request for a team Jul 28, 2022
dhayab approved these changes Aug 3, 2022
@Haroenv Haroenv enabled auto-merge (squash) Sep 5, 2022
@Haroenv Haroenv merged commit e7abf34 into master Sep 5, 2022
12 checks passed
@Haroenv Haroenv deleted the chore/deprecated-code branch Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants